Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace with MustAccAddressFromBech32 #108

Merged
merged 4 commits into from
Oct 31, 2023
Merged

chore: replace with MustAccAddressFromBech32 #108

merged 4 commits into from
Oct 31, 2023

Conversation

zakir-code
Copy link
Contributor

ref: #105

@zakir-code zakir-code requested a review from fx0x55 October 31, 2023 01:54
app/keepers/keepers.go Outdated Show resolved Hide resolved
app/keepers/keepers.go Outdated Show resolved Hide resolved
@fx0x55
Copy link
Contributor

fx0x55 commented Oct 31, 2023

@zakir-code This err is undefined, please fix it.

https://github.com/FunctionX/fx-core/blob/87071a39783b883eff15d5da49ff65bb19edf988/x/crosschain/keeper/attestation.go#L99C3-L99C6

Copy link
Contributor

@fx0x55 fx0x55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, THX

@fx0x55 fx0x55 merged commit 7cfe371 into main Oct 31, 2023
6 checks passed
@fx0x55 fx0x55 deleted the zakir/lint branch October 31, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants